Implement repo priorities. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the redundant NeedsInstallation check from install.FromRepo. In all calls of FromRepo, prior checks have already been performed and this extra check breaks priority rollbacks.
adjackura
requested changes
Apr 3, 2024
goolib/goospec_test.go
Outdated
| v2 string | ||
| want int | ||
| }{ | ||
| {500, "1.2.3@1", 500, "1.2.3@2", -1}, |
There was a problem hiding this comment.
Can you add a short description to each test case and print that when "got != tc.want"
|
PTAL |
adjackura
approved these changes
Apr 8, 2024
|
Can you rebase with the new repo changes (should be minor) |
Done. Sorry for the long delay, have been out on leave. Thanks for the review! |
If the already installed version is the exact same as the version available in a higher priority repo, then there is no reason to reinstall that version. Also added tests for the updates code.
|
PTAL: changed the updates logic to prevent unnecessary reinstalls and added some tests. |
adjackura
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integer priority value to repo entries in repo config files. If not specified, a default priority of 500 is used.
These priorities are associated with package versions in the map returned by client.AvailableVersions. When looking for the latest version, client.FindRepoLatest takes priorities into account such that a package version from a higher priority repo will always compare greater than any package version from a lower priority repo.
During "googet install" the highest priority version will be installed if the package is not already installed, otherwise the install logic remains the same if the package is already installed.
During "googet update" versions with priority greater than the default priority of 500 will take precedence over installed versions. The highest priority version will be installed even if it means downgrading the installed version in order to facilitate rollbacks.